-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheet): maybe get null when get active sheet #2512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dushusir
force-pushed
the
dushusir/sheet-tab
branch
from
June 13, 2024 11:50
d7f54e3
to
fc8a12f
Compare
wzhudev
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
View Deployment
|
Dushusir
force-pushed
the
dushusir/sheet-tab
branch
from
June 14, 2024 08:08
3817aa1
to
3330632
Compare
Dushusir
force-pushed
the
dushusir/sheet-tab
branch
from
June 14, 2024 08:40
43d7a64
to
002198d
Compare
Dushusir
force-pushed
the
dushusir/sheet-tab
branch
from
June 14, 2024 08:49
002198d
to
f2c62ba
Compare
wzhudev
reviewed
Jun 15, 2024
packages/sheets-numfmt/src/controllers/__tests__/editor.controller.spec.ts
Outdated
Show resolved
Hide resolved
Dushusir
force-pushed
the
dushusir/sheet-tab
branch
from
June 15, 2024 07:30
f8164d0
to
4fc3882
Compare
Dushusir
force-pushed
the
dushusir/sheet-tab
branch
from
June 15, 2024 07:36
4fc3882
to
d3d847c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist