Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): maybe get null when get active sheet #2512

Merged
merged 6 commits into from
Jun 15, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jun 13, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jun 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 14.45783% with 213 lines in your changes missing coverage. Please review.

Project coverage is 27.16%. Comparing base (b6ef910) to head (d3d847c).

Files Patch % Lines
...e/src/controllers/sheet-find-replace.controller.ts 0.00% 15 Missing ⚠️
...ckages/sheets-ui/src/controllers/menu/menu-util.ts 7.14% 13 Missing ⚠️
...atting-ui/src/components/panel/rule-list/index.tsx 0.00% 9 Missing ⚠️
.../render-controllers/selection.render-controller.ts 0.00% 9 Missing ⚠️
...lers/render-controllers/sheet-render.controller.ts 0.00% 7 Missing ⚠️
...s-data-validation/src/controllers/dv.controller.ts 0.00% 6 Missing ⚠️
packages/facade/src/apis/sheets/f-workbook.ts 37.50% 5 Missing ⚠️
...atting-ui/src/components/panel/rule-edit/index.tsx 0.00% 5 Missing ⚠️
...-conditional-formatting-ui/src/menu/manage-rule.ts 0.00% 5 Missing ⚠️
...ers/render-controllers/freeze.render-controller.ts 0.00% 5 Missing ⚠️
... and 62 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2512      +/-   ##
==========================================
- Coverage   27.17%   27.16%   -0.02%     
==========================================
  Files        1654     1654              
  Lines       83352    83476     +124     
  Branches    17266    17356      +90     
==========================================
+ Hits        22654    22673      +19     
- Misses      60698    60803     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir merged commit 85e15af into dev Jun 15, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/sheet-tab branch June 15, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants