Reorder list item behaviour is not correct when moving up

[cherreman]

When reordering items in a list, the following behaviour is applied:

• move down: the item below the dragged item is moved up when the bottom of the dragged item crosses the vertical center of the item below
• move up: the item above the dragged item is moved down when the bottom of the dragged item crosses the vertical center of the item above

The latter is not correct IMO since it should move the item above when the top of the dragged item crosses the vertical center of the item above.

The following code fixes this behaviour (the topSibling.offsetHeight should also be added in the first if-statement):

if(topSibling && (thisOffsetTop < topSibling.offsetTop + topSibling.offsetHeight + topSibling.offsetHeight/2)) {
    ionic.DomUtil.swapNodes(this._currentDrag.placeholder, topSibling);
    return index - 1;
} else if(bottomSibling && thisOffsetTop > (bottomSibling.offsetTop + bottomSibling.offsetHeight/2)) {
    ionic.DomUtil.swapNodes(bottomSibling, this._currentDrag.placeholder);
    return index + 1;
}

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.