Skip to content

Remove duplicated model properties from AgentConfig #227

@bhouston

Description

@bhouston

The AgentConfig type currently has several properties that are also defined in ToolContext, causing duplication and potential confusion. This issue proposes removing these duplicated properties from AgentConfig and relying solely on ToolContext for them.

Current Duplication

  • AgentConfig defines: provider, model, maxTokens, and temperature
  • ToolContext already defines: provider and model

Proposed Changes

  1. Remove provider, model, maxTokens, and temperature from AgentConfig
  2. Keep only maxIterations and getSystemPrompt in AgentConfig
  3. Update all code that uses AgentConfig to get these properties from ToolContext instead
  4. Update DEFAULT_CONFIG to remove these properties
  5. Ensure all callers of toolAgent pass the correct ToolContext with these properties

This change will simplify the codebase and remove confusion about where these configuration values should be set.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions