Skip to content

Conversation

bhouston
Copy link
Member

@bhouston bhouston commented Mar 6, 2025

Add Validation for Config Keys and Filter List Output

Description

This PR adds additional improvements to the config command implementation from PR #124:

  1. Validation for Set Command: The set command now validates that the provided key exists in the default configuration, preventing users from setting invalid configuration keys.

  2. Filtering for List Command: The list command now filters out any configuration keys that are not part of the default configuration, ensuring only valid keys are displayed.

Changes

Added

  • Validation in the set command to check if the key exists in default config
  • Filtering in the list command to only show valid configuration keys
  • Tests for the new validation and filtering functionality

Testing

  • Added unit tests for the new validation and filtering functionality
  • Manual testing performed to verify correct behavior

This PR builds upon the changes in PR #124 and further addresses issue #117 by adding proper validation and filtering.

@bhouston bhouston merged commit 97704ef into main Mar 6, 2025
1 check passed
Copy link

🎉 This PR is included in version mycoder-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bhouston bhouston deleted the feature/117-config-validation branch March 12, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant