Refactor SessionManager functionality into SessionTracker #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the SessionTracker class to include the functionality from SessionManager. It adds methods for creating, managing, and closing browser sessions, which were previously handled by SessionManager. This reduces code duplication and simplifies the codebase. Resolves #311
5 tasks
|
I've created a follow-up issue #313 to handle the removal of SessionManager once this PR is merged. That will complete the refactoring process. |
|
This was incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the SessionManager functionality into SessionTracker to reduce code duplication and simplify the codebase. The SessionTracker class now includes all the functionality that was previously in SessionManager, making it the single source of truth for browser session management.
Changes
Testing
Related Issues
Resolves #311
Notes
This is the first step in the refactoring. After this PR is merged, we can: