[SQLite]: Add support for blob SQL type in relational queries
#2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colonel-Sandvich
force-pushed
the
main
branch
2 times, most recently
from
87a7e25
to
96ae030
Compare
SQLite does not support selecting a blob type column in 'json_array()' and this function is used in relational queries. Solve this by wrapping blob type columns in 'hex()' function to cast the blob to a hex string that we can parse back into a blob later. Said 'later' being the 'mapFromDriverValue' step where inside this function we turn the hex string back into a buffer before passing it along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite does not support selecting a blob type column in
json_array()and this function is used in relational queries. Solve this by wrapping blob type columns in 'hex()' function to cast the blob to a hex string that we can parse back into a blob later. Later meaning, themapFromDriverValuestep where inside this function we turn the hex string back into a buffer before passing it along.Closes #2171
TODO: