Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone Wall 3.0.0 #31

Merged
merged 3 commits into from
Mar 5, 2016
Merged

Drone Wall 3.0.0 #31

merged 3 commits into from
Mar 5, 2016

Conversation

Tathanen
Copy link
Contributor

@Tathanen Tathanen commented Mar 2, 2016

Finally ready! v3 supports Drone v0.4.0, and comes with a slew of small UI and functional tweaks, along with a completely refreshed build process. Now an entirely client-side web application, you can build the wall with some settings and authorization items pre-baked, or be asked for them in the client when you first access it. The README should cover the bulk of it.

@bradrydzewski a couple requests for you. We had discussed earlier how the user/feed route was being rate-limited by GitHub because of a caching mechanism that hadn't been applied to that particular route. It would be ideal to have that issue fixed before merging this PR to prevent a slew of semi-functional walls from being deployed.

Also, could we assign this a 3.0.0 GitHub release? But before that, maybe assign 1.0.0 to 4fe1e5f and 2.0.0 to bc2f253? Thanks!

@athieriot
Copy link

That's sound fab ! Thanks. I am quite eager to test it to be honest.

One question though. Is there any reason why you got rid of the Dockerfile?

@Tathanen
Copy link
Contributor Author

Tathanen commented Mar 2, 2016

The dockerfile was a vestige of when this wasn't entirely client-side, I had never really used it in my development. That said, I'd be happy to restore it if people found it useful. What was your particular usecase, would you use docker to spin the wall up on a local machine?

@athieriot
Copy link

I use Docker a bit everywhere these days to be honest.

Running Drone Wall as a Docker container is definitively something I will use.
If you don't necessary have the interest for it I would happy to look at it after it has all been reviewed.

@Tathanen
Copy link
Contributor Author

Tathanen commented Mar 2, 2016

Sure, that works for me. I'd be happy to provide any info you need in a later PR.

@johnrengelman
Copy link

A Dockerfile that just runs Nginx and drops this code in as the static files would be great. Pretty painless to then throw that up in a Docker cluster to host it.

@microadam
Copy link

+1 for a dockerfile, makes it very easy to try out and run in an existing docker setup

@bradrydzewski
Copy link
Member

@Tathanen I'm working on the caching improvements now. I think I have everything in place but will need to spend some time testing tomorrow morning to be sure

@Tathanen
Copy link
Contributor Author

Tathanen commented Mar 4, 2016

@bradrydzewski 👍

@jackspirou
Copy link

Can't wait to try this out. Thanks @Tathanen and @bradrydzewski 👍

@bradrydzewski
Copy link
Member

@Tathanen just fixed the caching issue and published a new docker image. Feel free to merge this pull request whenever your ready

@Tathanen
Copy link
Contributor Author

Tathanen commented Mar 5, 2016

Sounds great. I actually don't have merge/release rights on the repo, would you mind granting me them?

@Tathanen
Copy link
Contributor Author

Tathanen commented Mar 5, 2016

... I should have checked that invite first, never mind!

@Tathanen Tathanen merged commit 2a72feb into drone:master Mar 5, 2016
@bradrydzewski
Copy link
Member

@Tathanen just setup the new version and it is awesome. Thanks so much for taking the time to upgrade and improve!

@Tathanen
Copy link
Contributor Author

Tathanen commented Mar 5, 2016

@bradrydzewski np, glad it's workin for ya! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants