stash: replace login to slug for FindLogin

[fitz123]

I didn't found any official description of slash's slug func, so This is pretty hack'y, but it makes the scm driver with logins like name.lastname@company.name at least usable

workaround for #31

[CLAassistant]

All committers have signed the CLA.

[bradrydzewski]

I appreciate the pull request. I would prefer not to implement a hack or workaround and would rather make a permanent fix. Can you have help me understand the root cause of the problem and how we could permanently fix?

[fitz123]

As you see here: f4d22d7#diff-91862817fc90c211ea4d5904438f4310R30
login is used to query user's account. But stash server expects slug instead. So username@domain.com has 404 result meanwhile username_domain.com would work.

I tried to map search request here #26 but I'm not so familiar with go but that could give you a clue of what going on

[fitz123]

Ideally instead of https://github.com/drone/go-scm/pull/25/files#diff-91862817fc90c211ea4d5904438f4310R31
one have to slugify login with stash'es slug algorithm. But I didn't find any code or documentation of how stash'es slugify works besides replacement I've used in the PR @ -> _

[gofort]

@bradrydzewski hi! I have the same problem in bitbucket ... Can you please merge provided by @fitz123 fix?

[bradrydzewski]

closing this in favor of the approach in #26