Implemented FindTag for github driver. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstrachan
pushed a commit
to jstrachan/go-scm
that referenced
this pull request
Dec 22, 2020
GitHub keeps multiple versions of a check with the same label. The API returns the list in reverse chronological order: https://developer.github.com/v3/repos/statuses/#list-statuses-for-a-specific-ref. The status resource in go-scm does not expose any information that might help distinguish between versions of checks with the same label. When a client of go-scm receives a list of statuses that contain duplicate labels, it has no way of finding out which one is the most recent one. Change the github driver to filter the statuses and only return one (the most recent) for each label. Fixes drone#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub API doesn't have a
/repo/{owner}/{repo}/tags/{tag}endpoint. However, it does have Git database API, which provides the/repo/{owner}/{repo}/git/ref/tags/{tag}endpoint. This PR implementsFindTagwith this API endpoint.