Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to subclass mock maker in dropwizard-servlets #6621

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

zUniQueX
Copy link
Member

@zUniQueX zUniQueX commented Feb 1, 2023

Problem:

The update to Mockito 5.x brought the new inlining mockmaker as default, which currently breaks our tests in the dropwizard-servlets module.

Solution:

Use the older subclassing mockmaker, which was the default in Mockito up to 5.x.

@zUniQueX zUniQueX added the task label Feb 1, 2023
@zUniQueX zUniQueX requested a review from a team as a code owner February 1, 2023 19:11
@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2023

@joschi joschi added this to the 3.0.0 milestone Feb 1, 2023
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zUniQueX Thanks! 😄

@joschi joschi merged commit c30b59c into dropwizard:release/3.0.x Feb 1, 2023
@zUniQueX zUniQueX deleted the fix-tests branch February 8, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants