Add response code meters for jetty9 #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
FYI - @joschi |
This was referenced Feb 12, 2023
joschi
added a commit
that referenced
this pull request
Feb 12, 2023
joschi
added a commit
that referenced
this pull request
Feb 12, 2023
joschi
added a commit
that referenced
this pull request
May 30, 2023
joschi
added a commit
that referenced
this pull request
May 30, 2023
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3043, we have use cases where we want to instrument specific server response codes instead of the aggregated 1xx/2xx/3xx/4xx/5xx meters.
This PR adds configurable individual response code meters in jetty. If this approach is acceptable, I'll create an accompanying PR in dropwizard to allow this to be specified in config via AbstractServerFactory
This change is backwards compatible and the default behavior will only include the existing 1xx/2xx/3xx/4xx/5xx meters. Can port this over to metrics-jetty10 and metrics-jetty11 modules as well.