Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANLGeoMag version 2.0.0-alpha #40

Merged
merged 58 commits into from
Feb 29, 2024
Merged

LANLGeoMag version 2.0.0-alpha #40

merged 58 commits into from
Feb 29, 2024

Conversation

drsteve
Copy link
Owner

@drsteve drsteve commented Dec 8, 2023

Branch for finalizing LGM v2. The sets of changes currently across other branches or PRs/draft PRs will be slowly migrated to this branch, with any updates or cleanup required along the way.

Once complete and tested, this branch will be merged into master and tagged as version 2.0.0-alpha.

Changes:

  • Bug fix: Correct altitude for lambda integrand in L* calculation
    • Update regression test to reflect expected change
  • Bug fix: Correct angle in Lgm_EarthEclipse
  • Bug fix: Correct intersection calculation for Lgm_Ellipse
  • API change: Add RelaxTolerance argument to FindShellLine
  • API change: Add ErrorStatus to all function variants of ComputeI_FromMltMlat
  • New function: Lgm_Terminator now added to library
  • Added trap in TS04 in case of evaluation deep inside Earth
  • Initial versions of Gaussian Process Regression routines
  • Updates for 2nd order calculation of 1st invariant
  • Extra checks in Lgm_QinDenton to reduce unnecessary output and check for inputs with standard QD naming convention ([1min, 5min, hour], in that priority order)
  • Add FluxTubeVolume and Lgm_ReplaceSubString2
  • Some updates to example codes (e.g., new Geodetic2)
  • Tighten default magstep tolerance (Bulirsch-Stoer relative tol from 1e-5 to 0; abs tolerance remains unchanged at 1e-5)
  • Added Lgm_B_FromScatteredData6
  • Added preliminary functions for conversion to magnetic field-aligned coordinates (PQB)

mghenderson64 and others added 30 commits December 7, 2023 16:19
…ius of r=1.0. Modified to use Lgm_LossConeHeight

distance above 1.0 instead.
These updates were part of a housekeeping update for better
handling of multiple minima when tracing drift shells
Previous version used legacy [1min, 1hr] naming and would report
multiple failures to find a valid input file. This enforces the checks
or output and updates the file resolution checks
@drsteve drsteve marked this pull request as ready for review February 13, 2024 22:58
@drsteve
Copy link
Owner Author

drsteve commented Feb 13, 2024

There are still a handful of changes from #39 that aren't reflected here. These fall into a few key categories:

  • KdTree updates: These should be easy enough to pull over, but need some more untangling of commits
  • FluxToPsd updates: These are API-breaking and the new functionality needs pulling out into new functions. This will be a separate branch/PR.
  • Shabansky orbit handling updates: This currently breaks the tests. If there are pieces I can pull in here without too much effort then I will. Otherwise this is a separate branch/PR to finish including the updates.
  • Additional minor changes that need testing before merge (e.g., Maxwell-Juttner updates, Lgm_Trace updates for minimum finding)

I'm taking this out of draft status as a sign of near-completion. Remaining updates will be triaged and either moved to a separated effort to incorporate or included here prior to merge. This branch is just about ready for testing with any downstream applications.

@drsteve drsteve changed the title DRAFT: LANLGeoMag version 2.0.0-alpha LANLGeoMag version 2.0.0-alpha Feb 23, 2024
@drsteve
Copy link
Owner Author

drsteve commented Feb 29, 2024

To be done post merge:

  • Tag as v2.0.0-alpha so we get a Zenodo release and a GH tag. Finalize as v2.0.0 after testing with downstream apps
  • New PR to fix up GPRv3 and include it in the build
  • New PR to update the initialization/setter/destructor for MagEphemData and MagEphemInfo for consistency with structures
  • New issue to log that a way of setting the PN model is required for calculating the eclipse flag in WriteMagEphemData
  • Review whether a4481a5 (in Feature expansion and some cleanup #39) can/should be merged. Currently it seems not, due to missing text files.
  • New PR to resolve Lgm_Trace updates
  • New PR to resolve Shabansky handling updates
  • New PR to resolve updates adding uncertainty tracking to FluxToPsd, etc.

@drsteve drsteve merged commit 2c98779 into master Feb 29, 2024
1 check passed
@drsteve drsteve mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants