Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-320-objectmeta-crd #321

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

AdheipSingh
Copy link
Contributor

@AdheipSingh AdheipSingh commented Nov 27, 2022

Fixes #320

Description

  • with crd conversion objectmeta field goes out.

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • MyFoo
  • OurBar
  • TheirBaz

@AdheipSingh AdheipSingh mentioned this pull request Dec 9, 2022
@AdheipSingh
Copy link
Contributor Author

@xvrl can you help in merging this one. Breaking master fix.

@AdheipSingh AdheipSingh reopened this Dec 13, 2022
@xvrl
Copy link
Member

xvrl commented Jan 4, 2023

@AdheipSingh I'm not familiar enough with the operator codebase to review this. @nishantmonu51 can you help find someone to review this?

@jwitko
Copy link

jwitko commented Feb 10, 2023

Any chance for a review/merge on this ? seems to be breaking basic functionality

@churromorales
Copy link

is this project no longer maintained?

@AdheipSingh
Copy link
Contributor Author

@churromorales @jwitko
#329

@gianm gianm merged commit ca94e43 into druid-io:master Feb 14, 2023
@AdheipSingh
Copy link
Contributor Author

@jwitko @churromorales the repo and the codebase will be maintained.

hampycapper pushed a commit to confluentinc/druid-operator that referenced this pull request Mar 9, 2023
hampycapper added a commit to confluentinc/druid-operator that referenced this pull request Mar 9, 2023
Co-authored-by: AdheipSingh <34169002+AdheipSingh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate ObjectMeta to true in CRD
5 participants