feat: Move policy/v1beta1 to policy/v1 for K8s 1.25+ compatability #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwitko
force-pushed
the
feature/move-policy-v1beta1-to-v1
branch
from
17247f3
to
f8eda76
Compare
|
I was able to build an image and test this in my cluster. Where it previously could not create past the historical pod it now generates all pods correctly. |
|
@jwitko thanks. Also i wanting to do the same for HPA api too. |
AdheipSingh
approved these changes
Feb 14, 2023
Yes, that one is removed in 1.26 which is an active current release. I wasn't sure if this style PR would be appropriate or if it would be required to support both old and new. I can try to do the latter in this PR if required but it may get tricky in some parts. |
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Update License
update README badge
[WIP] e2e tests
…tent make nodeSelector consistent
…les/github.com/prometheus/client_golang-1.11.1 Bump github.com/prometheus/client_golang from 1.11.0 to 1.11.1
remove functional dependency on empty objects
jwitko
force-pushed
the
feature/move-policy-v1beta1-to-v1
branch
from
f8eda76
to
63e1ef6
Compare
|
Closing because it was merged in new repo datainfrahq/druid-operator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Description
This PR moves
policy/v1beta1topolicy/v1for the PodDisruptionBudget.policy/v1beta1was deprecated in K8s 1.21 and removed in 1.25. It should be noted that this PR will make K8s <1.21 unsupported.This PR has:
Key changed/added files in this PR
PodDisruptionBudget