Add is_active flag to admin template #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubickcz
force-pushed
the
add_option_to_deactivate_admin_template
branch
2 times, most recently
from
66f7502 to
e8b3683
Compare
rubickcz
force-pushed
the
add_option_to_deactivate_admin_template
branch
from
e8b3683 to
641cf74
Compare
matllubos
reviewed
Jul 23, 2020
pynotify/handlers.py
Outdated
| Returns ``True`` if handler should handle creating of notification(s). | ||
| """ | ||
| return True | ||
| return not self._admin_template or self._admin_template and self._admin_template.is_active |
There was a problem hiding this comment.
there can be
not self._admin_template or self._admin_template.is_active
the middle part is not required
rubickcz
force-pushed
the
add_option_to_deactivate_admin_template
branch
from
641cf74 to
2071aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set an admin template as inactive, which effectively disables creation of new notifications for given type (template slug). The flag can be easily set from administration, since it's located directly on model.