Allow getenv() to work again with vlucas/phpdotenv 5.x #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelpittet Using createImmutable is the recommend ways to use library and we updated our examples in this repo accordingly. 2d48c40 Could you try to update your project? I would review a PR to change the code in Drush. |
normanlolx
reviewed
Dec 27, 2020
| $dotenv = Dotenv::createImmutable(__DIR__); | ||
| $dotenv->safeLoad(); | ||
| $dotenv = Dotenv::createUnsafeImmutable(__DIR__); | ||
| $dotenv->load(); |
There was a problem hiding this comment.
Is there a reason you switched safeLoad for load here? Drush site install now fails when there's no .env file around.
There was a problem hiding this comment.
That's just the docs indicating load() is the way to do it. I think I need a PR for Drush too.
There was a problem hiding this comment.
Reading the method and yeah thanks for keeping it safeLoad()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/vlucas/phpdotenv no longer works with getenv() by default in 5.x, you need to call explicitly
Dotenv::createUnsafeImmutableto have those calls work. There are may places that usegetenv()calls still including Drush.