Fixes #9: Do not download the scaffold files after composer install.
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; only do it after 'composer update', or when explicitly requested.
This was referenced Dec 22, 2015
Closed
Closed
|
Looks fine to me. |
derhasi
added a commit
that referenced
this pull request
Jan 12, 2016
Fixes #9: Do not download the scaffold files after `composer install`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the scaffold files are only downloaded after
composer update, or when explicitly requested. See #9 for details.I also changed the 'scaffold' custom command to always write the autoload.php file, since this should always be desired. We could go back to making this a separate option, but then users would need two entries in their
scriptssection (one for scaffold, and one for autoload), and would need to call both operations to download the scaffold files the first time. This would be cumbersome, and the benefit of separation seems minimal to me.