Skip to content

Pretty name for sort by field #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Pretty name for sort by field #10

wants to merge 3 commits into from

Conversation

Pasqualle
Copy link
Contributor

  • Fixed the name of the sort by field.
  • Fixed some comments.
  • Found a bug in getContextualArguments() function.

Untested code..

@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (8.x-1.x@40d0a16). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             8.x-1.x      #10   +/-   ##
==========================================
  Coverage           ?   77.06%           
==========================================
  Files              ?       23           
  Lines              ?      702           
  Branches           ?        0           
==========================================
  Hits               ?      541           
  Misses             ?      161           
  Partials           ?        0
Impacted Files Coverage Δ
src/Plugin/views/display/GraphQL.php 43.2% <100%> (ø)
src/Plugin/Deriver/Fields/ViewDeriver.php 98.36% <100%> (ø)
src/Plugin/Deriver/Enums/ViewSortByDeriver.php 95.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d0a16...f153a70. Read the comment docs.

@Pasqualle Pasqualle closed this Apr 18, 2018
@Pasqualle Pasqualle reopened this Apr 18, 2018
@fubhy
Copy link
Contributor

fubhy commented Nov 22, 2018

Thanks for the pull request and sorry for not checking it out earlier. The names of the types should be fixed already.

@fubhy fubhy closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants