Skip to content

Conversation

simon-tma
Copy link

This fixes an edge case bug when using drush site:install with an existing config that enabled graphql_core. As the dependency on path_alias isn't specified, the path_alias.manager service is not guaranteed to exist by the time graphql_core is installed.

This does not happen when enabling graphql_core in an existing site as path_alias is already enabled by then.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Patch and project coverage have no change.

Comparison is base (8418bb7) 78.72% compared to head (bf1348d) 78.72%.
Report is 3 commits behind head on 8.x-3.x.

❗ Current head bf1348d differs from pull request most recent head a309139. Consider uploading reports for the commit a309139 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             8.x-3.x    #1110   +/-   ##
==========================================
  Coverage      78.72%   78.72%           
  Complexity      1139     1139           
==========================================
  Files            192      192           
  Lines           3027     3027           
==========================================
  Hits            2383     2383           
  Misses           644      644           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trwill
Copy link

trwill commented Oct 19, 2021

This definitely fixed an issue during drush site-install for us where the dependency wasn't ready in time. I think this is probably a drupal 8.x issue only and wouldn't appear in a 9.x but nonetheless was needed to install the site! Any chance this can get merged? Else module is basically incompatible w/ 8.x drupal

@Luigisa Luigisa merged commit 054d02d into drupal-graphql:8.x-3.x Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants