Skip to content

Fix Explorer with Layout Builder enabled #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MurzNN
Copy link

@MurzNN MurzNN commented Jan 11, 2021

Rerolled patch from #733 (comment)
Closes #1088

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #1144 (9885d96) into 8.x-3.x (8418bb7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-3.x    #1144      +/-   ##
=============================================
+ Coverage      78.72%   78.75%   +0.02%     
- Complexity      1139     1142       +3     
=============================================
  Files            192      192              
  Lines           3027     3031       +4     
=============================================
+ Hits            2383     2387       +4     
  Misses           644      644              
Impacted Files Coverage Δ Complexity Δ
src/Plugin/GraphQL/Schemas/SchemaPluginBase.php 79.75% <100.00%> (+0.50%) 53.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8418bb7...9885d96. Read the comment docs.

@klausi klausi added the 3.x label Jan 12, 2021
@bronius
Copy link

bronius commented Jul 8, 2021

Hi - Thanks for the patch. I don't know enough about this and my current configuration to speak too informedly here just yet, but at the moment, I confirm the patch applies but does not resolve the original issue in #733 (Console reads: Uncaught TypeError: Cannot read property '__schema' of undefined, and Explore screen is blank) in at least my use case. In my use case, when I click into /admin/config/graphql/schemas I see only "Default : GraphQL Core" listed.

@Luigisa
Copy link

Luigisa commented Sep 7, 2023

This request has been included in the new versions of the 3.x module.
Thanks @MurzNN and @bronius

@Luigisa Luigisa closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants