Simplify assertResultErrors to avoid closure serialization #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kingdutch
force-pushed
the
bugfix/closure-serialization
branch
from
258989b to
0b19d10
Compare
This commit changes some loops into built-in PHP functions to simplify the code and eliminate the need for closures. Additionally this switches over to an `assertEmpty` from `assertEquals`. This achieves the same test result and in the message still provides the errors. However it prevents test failures with weird serialization complaints that are caused by closures in function arguments of GraphQL Error stacktraces. See sebastianbergmann/phpunit#4371 (comment) The downside to this change is that we may lose some contextual information that the full error in the array comparison may provide. The upside is that we can actually see why tests fail since in a lot of cases this beneficial diff doesn't make it into the test output anyway. So all-in-all this is a step forward.
Kingdutch
force-pushed
the
bugfix/closure-serialization
branch
from
0b19d10 to
3a98c22
Compare
|
Thanks, makes sense to me! |
klausi
pushed a commit
to klausi/graphql
that referenced
this pull request
Sep 21, 2023
…ization (drupal-graphql#1159) This commit changes some loops into built-in PHP functions to simplify the code and eliminate the need for closures. Additionally this switches over to an `assertEmpty` from `assertEquals`. This achieves the same test result and in the message still provides the errors. However it prevents test failures with weird serialization complaints that are caused by closures in function arguments of GraphQL Error stacktraces. See sebastianbergmann/phpunit#4371 (comment) The downside to this change is that we may lose some contextual information that the full error in the array comparison may provide. The upside is that we can actually see why tests fail since in a lot of cases this beneficial diff doesn't make it into the test output anyway. So all-in-all this is a step forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes some loops into built-in PHP functions to simplify
the code and eliminate the need for closures.
Additionally this switches over to an
assertEmptyfromassertEquals.This achieves the same test result and in the message still provides the
errors. However it prevents test failures with weird serialization
complaints that are caused by closures in function arguments of GraphQL
Error stacktraces. See sebastianbergmann/phpunit#4371 (comment)
The downside to this change is that we may lose some contextual
information that the full error in the array comparison may provide. The
upside is that we can actually see why tests fail since in a lot of
cases this beneficial diff doesn't make it into the test output anyway.
So all-in-all this is a step forward.