Skip to content

Conversation

fubhy
Copy link
Contributor

@fubhy fubhy commented Jan 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #476 into 8.x-3.x will decrease coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           8.x-3.x     #476      +/-   ##
===========================================
- Coverage    80.07%   79.88%   -0.19%     
===========================================
  Files          239      239              
  Lines         3553     3674     +121     
===========================================
+ Hits          2845     2935      +90     
- Misses         708      739      +31
Impacted Files Coverage Δ
modules/graphql_core/src/TypeMapper.php 93.75% <66.66%> (-6.25%) ⬇️
...core/src/Plugin/GraphQL/Fields/Context/Context.php 23.4% <0%> (-29.54%) ⬇️
...breadcrumbs_test/src/Controller/TestController.php 0% <0%> (ø) ⬆️
...re/src/Plugin/GraphQL/Interfaces/Entity/Entity.php 59.58% <0%> (+59.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54fc51...d578aac. Read the comment docs.

@captaindav
Copy link

I tried this PR but got different error than before, shown below.

The website encountered an unexpected error. Please try again later.
Recoverable fatal error: Argument 2 passed to Drupal\graphql\GraphQL\Execution\Processor::deferredResolve() must implement interface Youshido\GraphQL\Field\FieldInterface, instance of Closure given, called in /var/www/agency/vendor/youshido/graphql/src/Execution/Processor.php on line 499 and defined in Drupal\graphql\GraphQL\Execution\Processor->deferredResolve() (line 81 of /var/www/agency/modules/graphql/src/GraphQL/Execution/Processor.php).
Drupal\graphql\GraphQL\Execution\Processor->deferredResolve(Object, Object) (Line: 499)
Youshido\GraphQL\Execution\Processor->resolveObject(Object, Object, NULL) (Line: 190)
Youshido\GraphQL\Execution\Processor->resolveField(Object, Object) (Line: 152)
Youshido\GraphQL\Execution\Processor->resolveQuery(Object) (Line: 89)
Youshido\GraphQL\Execution\Processor->processPayload(' query IntrospectionQuery {
__schema {
queryType { name }
mutationType { name }
subscriptionType { name }
types {
...FullType
}
directives {
name
description
locations
args {
...InputValue
}
}
}
}

fragment FullType on __Type {
  kind
  name
  description
  fields(includeDeprecated: true) {
    name
    description
    args {
      ...InputValue
    }
    type {
      ...TypeRef
    }
    isDeprecated
    deprecationReason
  }
  inputFields {
    ...InputValue
  }
  interfaces {
    ...TypeRef
  }
  enumValues(includeDeprecated: true) {
    name
    description
    isDeprecated
    deprecationReason
  }
  possibleTypes {
    ...TypeRef
  }
}

fragment InputValue on __InputValue {
  name
  description
  type { ...TypeRef }
  defaultValue
}

fragment TypeRef on __Type {
  kind
  name
  ofType {
    kind
    name
    ofType {
      kind
      name
      ofType {
        kind
        name
        ofType {
          kind
          name
          ofType {
            kind
            name
            ofType {
              kind
              name
              ofType {
                kind
                name
              }
            }
          }
        }
      }
    }
  }
}', Array) (Line: 93)

Drupal\graphql\GraphQL\Execution\QueryProcessor->processQuery('default', ' query IntrospectionQuery {
__schema {
queryType { name }
mutationType { name }
subscriptionType { name }
types {
...FullType
}
directives {
name
description
locations
args {
...InputValue
}
}
}
}

fragment FullType on __Type {
  kind
  name
  description
  fields(includeDeprecated: true) {
    name
    description
    args {
      ...InputValue
    }
    type {
      ...TypeRef
    }
    isDeprecated
    deprecationReason
  }
  inputFields {
    ...InputValue
  }
  interfaces {
    ...TypeRef
  }
  enumValues(includeDeprecated: true) {
    name
    description
    isDeprecated
    deprecationReason
  }
  possibleTypes {
    ...TypeRef
  }
}

fragment InputValue on __InputValue {
  name
  description
  type { ...TypeRef }
  defaultValue
}

fragment TypeRef on __Type {
  kind
  name
  ofType {
    kind
    name
    ofType {
      kind
      name
      ofType {
        kind
        name
        ofType {
          kind
          name
          ofType {
            kind
            name
            ofType {
              kind
              name
              ofType {
                kind
                name
              }
            }
          }
        }
      }
    }
  }
}') (Line: 131)

Drupal\graphql\GraphQL\Utility\Introspection->introspect('default') (Line: 78)
Drupal\graphql\Controller\ExplorerController->viewExplorer('default', Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber{closure}() (Line: 576)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber{closure}()
call_user_func_array(Object, Array) (Line: 153)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 67)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 38)
Drupal\jsonapi\StackMiddleware\FormatSetter->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

@fubhy
Copy link
Contributor Author

fubhy commented Jan 23, 2018

@captaindav That error is not related to this pull request but the upgrade of the youshido/graphql library. You can't just go into the graphql module directory and do a "git pull". You need to actually install the module again like so: "composer require drupal/graphql:3.x-dev" and THEN apply the patch. Alternative: Cherry pick the pull request's commit onto your current version with git. I'd suggest the first option though :)

@fubhy fubhy force-pushed the allow-dynamic-entity-reference branch from 212bbf4 to d578aac Compare January 23, 2018 05:21
@fubhy fubhy merged commit c62a342 into 8.x-3.x Jan 23, 2018
@fubhy
Copy link
Contributor Author

fubhy commented Jan 23, 2018

Tested with the outline module. Works!

@fubhy fubhy deleted the allow-dynamic-entity-reference branch January 23, 2018 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants