Skip to content

SubRequestResponse:result is an array. #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2018
Merged

SubRequestResponse:result is an array. #491

merged 1 commit into from
Jan 30, 2018

Conversation

martinfrances107
Copy link
Contributor

I just noticed a small flaw while looking at SubRequestResponse:result

The constructor specifies that the parameter $result is an array. So this means documenting various parts of the class as 'mixed' is not correct.

A very minor fix... I hope this is appropriate/welcome.

@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #491 into 8.x-3.x will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           8.x-3.x     #491      +/-   ##
===========================================
+ Coverage    80.32%   81.07%   +0.75%     
===========================================
  Files          242      242              
  Lines         3736     3557     -179     
===========================================
- Hits          3001     2884     -117     
+ Misses         735      673      -62
Impacted Files Coverage Δ
src/GraphQL/Buffers/SubRequestResponse.php 100% <ø> (ø) ⬆️
...breadcrumbs_test/src/Controller/TestController.php 0% <0%> (ø) ⬆️
...core/src/Plugin/GraphQL/Fields/Context/Context.php 36.36% <0%> (+11.87%) ⬆️
...re/src/Plugin/GraphQL/Interfaces/Entity/Entity.php 100% <0%> (+40.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e0f3d...9d3222f. Read the comment docs.

@fubhy fubhy merged commit 4a826f0 into drupal-graphql:8.x-3.x Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants