Skip to content

Conversation

fubhy
Copy link
Contributor

@fubhy fubhy commented Feb 16, 2018

No description provided.

@fubhy fubhy force-pushed the webonyx branch 2 times, most recently from 1cb5fd7 to 4d5ca2e Compare February 16, 2018 13:26
@fubhy fubhy force-pushed the webonyx branch 2 times, most recently from 721cccc to 0118bf0 Compare February 16, 2018 15:08
@sebas5384
Copy link
Contributor

@fubhy and @pmelab this means we are opening the door to be able to use files like schema.graphql to declare schema?

@fubhy
Copy link
Contributor Author

fubhy commented Feb 16, 2018

@sebas5384 yes, theoretically we can even look into generating our plugins based on that. Let's see.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #525 into 8.x-3.x will decrease coverage by 0.01%.
The diff coverage is 87.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           8.x-3.x     #525      +/-   ##
===========================================
- Coverage    79.14%   79.12%   -0.02%     
===========================================
  Files          195      181      -14     
  Lines         2704     2716      +12     
===========================================
+ Hits          2140     2149       +9     
- Misses         564      567       +3
Impacted Files Coverage Δ
src/Annotation/GraphQLAnnotationBase.php 75% <ø> (ø) ⬆️
...lugin/MenuLink/Deriver/ExplorerMenuLinkDeriver.php 100% <ø> (ø) ⬆️
src/Routing/ConfigurationRoutes.php 0% <ø> (ø) ⬆️
src/Routing/ExplorerRoutes.php 100% <ø> (ø) ⬆️
src/Routing/VoyagerRoutes.php 100% <ø> (ø) ⬆️
...Plugin/MenuLink/Deriver/VoyagerMenuLinkDeriver.php 100% <ø> (ø) ⬆️
src/Controller/SchemaOverviewController.php 0% <ø> (ø) ⬆️
...in/GraphQL/Fields/Entity/Fields/Image/ImageUrl.php 0% <0%> (ø) ⬆️
...lugin/GraphQL/Fields/Entity/EntityRevisionById.php 44% <0%> (ø) ⬆️
...ql_core/src/Plugin/GraphQL/Fields/Link/LinkUrl.php 0% <0%> (ø) ⬆️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3e908...e803d2c. Read the comment docs.

@fubhy fubhy merged commit 2132807 into 8.x-3.x Mar 8, 2018
@fubhy fubhy deleted the webonyx branch March 8, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants