Skip to content

Fixes #683: Bundle-specific fields were bound to the entity type inte… #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

pmelab
Copy link
Contributor

@pmelab pmelab commented Jul 23, 2018

…rface.

@pmelab
Copy link
Contributor Author

pmelab commented Jul 23, 2018

This should fix #638 and #615.

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #640 into 8.x-3.x will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           8.x-3.x     #640     +/-   ##
==========================================
+ Coverage    79.11%   79.22%   +0.1%     
==========================================
  Files          187      187             
  Lines         2950     2951      +1     
==========================================
+ Hits          2334     2338      +4     
+ Misses         616      613      -3
Impacted Files Coverage Δ
...e/src/Plugin/Deriver/Fields/EntityFieldDeriver.php 92.1% <100%> (+8.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6488f5...49d3184. Read the comment docs.

@pmelab pmelab merged commit 6608c9d into 8.x-3.x Aug 6, 2018
@fubhy fubhy deleted the issue-638-fix-global-bundle-fields branch September 14, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant