Skip to content

Conversation

joaogarin
Copy link
Member

@joaogarin joaogarin commented Jan 25, 2019

Document more detailed information on Mutations. Feedback welcome, this is all based on my experience going through tests and other places where i could find some information so highly appreciate feedback on things that can be wrong or not totally accurate.

Things to cover in terms of basic mutations

  • CRUD Operations for Entities (CreateEntityBase)
  • Mutations not related to entities (MutationPluginBase)
  • Generating proper errors and violations
  • Folder structure for the plugin system
  • use statements and namespacing to your own module

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #718 into 8.x-3.x will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-3.x     #718      +/-   ##
=============================================
- Coverage       79.8%   79.74%   -0.06%     
- Complexity      1269     1270       +1     
=============================================
  Files            192      192              
  Lines           3144     3145       +1     
=============================================
- Hits            2509     2508       -1     
- Misses           635      637       +2
Impacted Files Coverage Δ Complexity Δ
src/Plugin/GraphQL/Schemas/SchemaPluginBase.php 82.45% <0%> (-0.59%) 61% <0%> (ø)
src/GraphQL/Execution/QueryProcessor.php 89.47% <0%> (-0.53%) 70% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73523c...01cf212. Read the comment docs.

@joaogarin joaogarin self-assigned this Jan 25, 2019
@joaogarin joaogarin changed the title WIP : Docs mutation plugins docs(mutations): Documentation for mutations Jan 27, 2019
@joaogarin joaogarin requested review from fubhy, justinlevi and pmelab and removed request for justinlevi January 27, 2019 09:58
Copy link
Contributor

@fubhy fubhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked a few typos and grammaer issues as well as general style issues (back ticks for code references, variable names, etc.). Can you proofread the PR once again and fix the things I brought up?

Thanks, reaaally good job! I was a bit shocked about how much documentation you are adding here. Really cool!

@joaogarin
Copy link
Member Author

Passed it all through a spell checker, also addressed the topics mentioned here. thanks for the feedback! ; )

@joaogarin joaogarin requested a review from fubhy February 15, 2019 09:56
@pmelab pmelab merged commit a8bc457 into drupal-graphql:8.x-3.x Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants