Skip to content

Entity revisions data producer #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rthideaway
Copy link
Contributor

Splitting up new data producers as agreed in #859
This PR introduces Entity revisions data producer

@joaogarin joaogarin requested a review from fubhy October 10, 2019 14:40
@rthideaway rthideaway requested a review from fubhy October 13, 2019 20:31
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #909 into 8.x-4.x will decrease coverage by 2.98%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-4.x     #909      +/-   ##
=============================================
- Coverage      64.62%   61.63%   -2.99%     
- Complexity       624      678      +54     
=============================================
  Files             93       95       +2     
  Lines           1340     1405      +65     
=============================================
  Hits             866      866              
- Misses           474      539      +65
Impacted Files Coverage Δ Complexity Δ
...QL/DataProducer/Field/EntityReferenceRevisions.php 0% <0%> (ø) 40 <40> (?)
src/GraphQL/Buffers/EntityRevisionBuffer.php 0% <0%> (ø) 14 <14> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c42886...d50b0d1. Read the comment docs.

@rthideaway
Copy link
Contributor Author

Adjusted access. Should be ready for re-review

@joaogarin joaogarin added the 4.x label Oct 15, 2019
@rthideaway
Copy link
Contributor Author

We have this problem on some other places in the code base (translations loaded after access check). If this gets approved and merged, will fix it also there.

@fubhy fubhy merged commit 9209b65 into drupal-graphql:8.x-4.x Oct 15, 2019
@fubhy
Copy link
Contributor

fubhy commented Oct 15, 2019

We have this problem on some other places in the code base (translations loaded after access check). If this gets approved and merged, will fix it also there.

Yes please. That would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants