Accept EntityTypeManagerInterface in TaxonomyLoadTree #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TaxonomyLoadTree producer only accepts the EntityTypeManager. This causes issues when the service is replaced by something else. An example is the service from the Web Profiler. By accepting the Interface instead, alternative implementations can be used while guaranteeing they provide the proper functionality. Fixes drupal-graphql#950
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #951 +/- ##
==========================================
Coverage 61.81% 61.81%
Complexity 678 678
==========================================
Files 95 95
Lines 1409 1409
==========================================
Hits 871 871
Misses 538 538
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TaxonomyLoadTree producer only accepts the EntityTypeManager. This causes issues when the service is replaced by something else. An example is the service from the Web Profiler.
By accepting the Interface instead, alternative implementations can be used while guaranteeing they provide the proper functionality.
Fixes #950