Merge caching for entity fields #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed an issue with missing caching tags when requesting long text fields (wysiwyg editor-enabled) with inline media. The cache tags of the inline media were not available in the response. I traced it down to this file (EntityFieldBase.php) in the graphql_core sub-module. With this small change, the caching tags set by the entity fields will be used in the response. And it solves the issue that a change of an image in a media item does not invalidate the cache of the pages where it is used in the long text fields.
Luigisa
approved these changes
Sep 7, 2023
|
Sorry, don't know the 3.x codebase well, removing myself as reviewer. |
Luigisa
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue with missing caching tags when requesting long text fields (wysiwyg editor-enabled) with inline media. The cache tags of the inline media were not available in the response. I traced it down to this file (EntityFieldBase.php) in the graphql_core sub-module.
With this small change, the caching tags set by the entity fields will be used in the response. And it solves the issue that a change of an image in a media item does not invalidate the cache of the pages where it is used in the long text fields.