This repository was archived by the owner on Jan 5, 2018. It is now read-only.
Issue #2566871 by Primsi: Better handle cardinality #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primsi
force-pushed
the
cardinality_handling
branch
from
23186c0 to
dd9c806
Compare
| entity_ids = existing_entities_array.join(' '); | ||
| } | ||
| else { | ||
| entity_ids = entity_ids + added_entities_array.join(' '); |
There was a problem hiding this comment.
Could this be
entity_ids = added_entities_array.join(' ');
dd9c806 to
06fe9da
Compare
| @@ -83,7 +90,7 @@ class IFrame extends DisplayBase implements DisplayRouterInterface { | |||
| public function __construct(array $configuration, $plugin_id, $plugin_definition, EventDispatcherInterface $event_dispatcher, RouteMatchInterface $current_route_match, UuidInterface $uuid, Request $request, CurrentPathStack $current_path) { | |||
| parent::__construct($configuration, $plugin_id, $plugin_definition, $event_dispatcher); | |||
| $this->currentRouteMatch = $current_route_match; | |||
| $this->uuid = $uuid; | |||
| $this->uuidService = $uuid; | |||
There was a problem hiding this comment.
Just one nit-pik. "$uuidGenerator" seems better name. What do you think?
primsi
force-pushed
the
cardinality_handling
branch
from
06fe9da to
23878d7
Compare
slashrsm
added a commit
that referenced
this pull request
Sep 25, 2015
Issue #2566871 by Primsi: Better handle cardinality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.