Updated for https://www.drupal.org/node/2310411. #87
Conversation
|
Somehow the embed form is skipping the second 'embed options' step of the form. Trying to figure out why. |
|
@davereid Same thing was happening with me when I was trying this. |
src/Form/EntityEmbedDialog.php
Outdated
There was a problem hiding this comment.
It appears this two can't be in main submit. It is also nicer if we separate diff buttons into diff functions.
Not sure what to do with errors handling, though (redundant code in both funcitons). submitForm() is not even called if validation fails so it can't be in there. Not sure if there is any suggested pattern how to handle this in AJAX. Would be nice to look into this but I'm unable ATM.
Selecting, settings, embeding now works again.
|
I'm just going to merge this for now. Obviously something more is wrong with Travis.CI and let's fix that separately rather than hold this up. |
No description provided.