2770757 implement promotion conditions #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branched off of #445 |
| $form += parent::buildConfigurationForm($form, $form_state); | ||
|
|
||
| $form['amount'] = [ | ||
| '#type' => 'commerce_price', |
There was a problem hiding this comment.
Need to extend FunctionalJavascript test for this.
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
4 times, most recently
from
11e59f8 to
ebd5e0f
Compare
| ]); | ||
|
|
||
| $fields['conditions'] = BaseFieldDefinition::create('commerce_plugin_item:commerce_promotion_condition') | ||
| ->setLabel(t('Offer')) |
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
from
ebd5e0f to
ba64052
Compare
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
9 times, most recently
from
fd4d164 to
1109f5e
Compare
| */ | ||
| public function getQuantity() { | ||
| return $this->get('quantity')->value; | ||
| return (string) $this->get('quantity')->value; |
There was a problem hiding this comment.
@bojanz so should we change the field type to be string, or store it as decimal and keep this cast?
There was a problem hiding this comment.
It would be more proper to change a field type, but that will probably require providing a custom widget. We can go with the cast and open a followup issue.
modules/price/src/Element/Price.php
Outdated
| if ($input !== FALSE && $input !== NULL && !empty($input['amount']) && !empty($input['currency_code'])) { | ||
| // Convert empty string value to numeric value. | ||
| if ($input['amount'] === '') { | ||
| if ($input['amount'] == '') { |
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
from
1109f5e to
e987bc4
Compare
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
from
e987bc4 to
3f98208
Compare
3 tasks
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
2 times, most recently
from
1f5d4d9 to
9ce67bd
Compare
| * The entity. | ||
| * | ||
| * @return bool | ||
| * Returns TRUE if promotion can be applied, or false if conditions failed. |
There was a problem hiding this comment.
We don't need "Returns", that's redundant. Just "TRUE if the promotion can be applied, FALSE otherwise."
| /** | ||
| * Defines an interface for Condition plugins. | ||
| * | ||
| * Extends the core Condition interface to support Commerce Promotion specific |
There was a problem hiding this comment.
Probably don't need to say "Commerce"? It's implied. The whole sentence feels redundant.
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
2 times, most recently
from
a1971f5 to
8ffb20f
Compare
| protected $entityTypeManager; | ||
|
|
||
| /** | ||
| * Constructs a ConditionManager object. |
There was a problem hiding this comment.
Constructs a new PromotionConditionManager object.
mglaman
force-pushed
the
2770757-implement-promotion-conditions
branch
from
8ffb20f to
0a09673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.