Simplify pattern matching tests #172
Conversation
Instead of showcasing different ways that pattern matching can be used on Ruby, just test what is specific to our implementation and remove the indirection in testing.
waiting-for-dev
force-pushed
the
waiting-for-dev/patter_match_tests
branch
from
2f01b5f
to
cb5460d
Compare
|
The point of these tests is not to test Ruby but to showcase using PM in your own code. Even though they were written back when PM was an experimental feature keeping them doesn't cost much so I'd leave them for those who poke around (myself included :). |
|
Thanks for clarifying @flash-gordon. As someone who took the first look at understanding how PM was implemented in dry-monads, those tests were a bit confusing to understand. Do you think those kinds of examples would have a better fit in the docs instead? 🤔 |
|
I agree on this, I was a but worried some changes in the lib (or in the lang) can break backward compatibility in special cases. I both explored the syntax and documented supported usages this way and made sure the lib doesn't break. At this point I think we can agree PM endured the test of time so these tests can be removed. It's for sure not a thing to have a lot of discussions about, I just explained my reasoning. |
|
Thanks for your understanding, @flash-gordon ❤️ |
Instead of showcasing different ways that pattern matching can be used on Ruby, just test what is specific to our implementation and remove the indirection in testing.