Adding box-shadow property, removing '$0' and adding max-(width/height) #20
Conversation
… for in-snippet snippeting
|
Also addressed #17 by removing the trailing '$0' at the end of snippets; tested on latest Atom with no issues |
|
Aaand just addressed #19 by adding max-width and max-height! |
neromaki
changed the title
| 'body': 'bottom: ${1:0}$0' | ||
| 'body': 'bottom: ${1:0}' | ||
| 'box-shadow': | ||
| 'prefix': 'boxs' |
There was a problem hiding this comment.
How about bs for the prefix. It makes it consistent with the other prefixes:
- When the rule is multiple words, I use the first letter from each word.
- When the rule is one word, I use the first 3 letters.
There was a problem hiding this comment.
Aah okay, good to be consistent!
Do you have any thoughts on aliases? (such as boxs in this instance)
There was a problem hiding this comment.
I'll have to think about the alias. I'm worried about taking over too many prefixes. Can you add it as a separate PR after this one is merged?
Btw, I have some more aliases that I want to add, like one for box:
'box':
'prefix': 'box'
'body': """
position: ${1:absolute};
top: ${2:0};
right: ${3:0};
bottom: ${4:0};
left: ${5:0};
content: '';$0
"""
It's probably not the best prefix name, but it is what I came up with at the time.
|
Awesome work. I added some inline comments. |
…consistent, and changing the (min/max)-(width/height) prefixes for clarity
|
Have committed some adjustments based on your feedback! |
| 'prefix': 'bs' | ||
| 'body': """ | ||
| // h-length, v-length, blur, spread, colour | ||
| box-shadow: ${1:0} ${2:3px} ${3:15px} ${4:1px} ${5:rgba(0, 0, 0, .5)}$0 |
|
Thanks @neromaki |
Adding a box-shadow property as I keep having to Google the parameter order, bonus that this also addresses one of the three support issues #18
Default parameter outputs put a Material Design-style card shadow emphasising the container "floating".
Also outputs a comment at the end of the line with the parameters for reference.