fix: check UNITY_LICENSE via env in workflow

[dsarno]

Summary

• fix invalid secrets reference in workflow conditions
• add job-level environment variable for UNITY_LICENSE

Testing

• pytest

---

https://chatgpt.com/codex/tasks/task_e_68a43b83c6c88327b89fa0840e3b8ab2

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/fix-workflow-file-unrecognized-named-value-errors

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

Greptile Summary

This PR fixes a GitHub Actions workflow syntax error in the claude-nl-suite.yml workflow file. The issue was that secrets.UNITY_LICENSE was being referenced directly in workflow conditions, which is not allowed in GitHub Actions due to security constraints. The secrets context can only be accessed in specific locations like environment variable assignments.

The fix involves two key changes:

1. Moving the UNITY_LICENSE environment variable from step-level to job-level scope, making it accessible throughout the entire job
2. Updating the conditional expressions in Unity compilation steps to reference env.UNITY_LICENSE instead of secrets.UNITY_LICENSE

This change maintains the exact same functional behavior - Unity compilation steps will only run when a Unity license is available - but uses the correct GitHub Actions syntax. The workflow is part of the Unity MCP project's CI/CD pipeline and ensures that Unity-specific build steps are conditionally executed based on license availability.

Important Files Changed

Click to expand file changes

Filename	Score	Overview
.github/workflows/claude-nl-suite.yml	5/5	Fixed GitHub Actions syntax by moving UNITY_LICENSE to job-level env and updating conditional references

Confidence score: 5/5

• This PR is safe to merge with minimal risk
• Score reflects a straightforward syntax fix that follows GitHub Actions best practices
• No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant GitHub
    participant Runner as "Ubuntu Runner"
    participant Python as "Python/uv"
    participant Claude as "Claude Action"
    participant Unity as "Unity Test Runner"

    User->>GitHub: "Trigger workflow_dispatch"
    GitHub->>Runner: "Start nl-suite job"
    Runner->>Runner: "Check workflow_dispatch condition"
    Runner->>Runner: "Set UNITY_LICENSE env from secrets"
    
    Runner->>GitHub: "Checkout repository (fetch-depth: 0)"
    Runner->>Python: "Install Python 3.11 + uv"
    Runner->>Python: "Install Unity MCP server deps if requirements.txt exists"
    
    Runner->>Claude: "Run Claude NL/T test suite"
    Claude->>Claude: "Execute with prompt_file: .claude/prompts/nl-unity-suite.md"
    Claude->>Claude: "Use allowed tools and MCP config"
    Claude-->>Runner: "Return test results"
    
    Runner->>GitHub: "Upload JUnit test artifacts"
    Runner->>GitHub: "Annotate PR with test results"
    
    alt Unity Project detected and UNITY_LICENSE available
        Runner->>Unity: "Run Unity compile (Project mode)"
        Unity-->>Runner: "Compilation results"
    else Unity Package detected and UNITY_LICENSE available
        Runner->>Unity: "Run Unity compile (Package mode)"
        Unity-->>Runner: "Compilation results"
    end
    
    Runner->>Runner: "Clean working tree (restore and clean)"
    Runner-->>GitHub: "Job complete"

Loading

_{1 file reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}