fix: detect Unity mode and secrets in workflow

[dsarno]

Summary

• detect Unity license and project/package mode
• guard Unity compile steps with detection outputs
• avoid failing test reporter when no results

Testing

• pytest
• yamllint .github/workflows/claude-nl-suite.yml (failed: command not found)

---

https://chatgpt.com/codex/tasks/task_e_68a444357fbc83279472a21bc58082d7

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/fix-unity-workflow-secret-handling

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

Greptile Summary

This PR enhances the Unity workflow robustness by implementing runtime detection for Unity license availability and project structure modes. The changes address workflow failures that occur when Unity secrets are missing or when the repository structure doesn't match expected Unity configurations.

The key improvement is the addition of a detection step that checks for the presence of UNITY_LICENSE secret and identifies whether the repository is configured as a Unity project (has ProjectSettings/ProjectVersion.txt) or package (has Packages/manifest.json without project settings). This detection logic replaces the previous approach of having UNITY_LICENSE set at the job level and using hashFiles() functions in conditionals, which could fail unexpectedly.

The workflow now conditionally executes Unity compilation steps only when both the license is available and the correct project structure is detected. Environment variables have been moved from job-level to step-level scope for better isolation. Additionally, the test reporter step includes fail-on-empty: false to prevent workflow failures when no test results are generated.

These changes make the workflow more suitable for repositories that may optionally include Unity components, improving the overall reliability of the CI/CD pipeline in the Unity MCP project ecosystem.

Important Files Changed

Files Modified

Filename	Score	Overview
.github/workflows/claude-nl-suite.yml	4/5	Enhanced Unity workflow with runtime detection of license and project structure to prevent failures

Confidence score: 4/5

• This PR is safe to merge with minimal risk as it improves workflow reliability without changing core functionality
• Score reflects solid defensive programming practices and clear improvement to CI/CD robustness
• No files require special attention as the changes are well-contained within the workflow configuration

Sequence Diagram

sequenceDiagram
    participant User
    participant GitHub
    participant Workflow as "claude-nl-suite workflow"
    participant Claude as "Claude NL/T Action"
    participant Unity as "Unity Test Runner"
    participant Artifacts as "GitHub Artifacts"

    User->>GitHub: "Trigger workflow_dispatch"
    GitHub->>Workflow: "Start nl-suite job"
    
    Workflow->>Workflow: "Checkout repository"
    Workflow->>Workflow: "Install Python + uv"
    Workflow->>Workflow: "Prepare Unity MCP server deps"
    
    Workflow->>Claude: "Run Claude NL/T test suite"
    Claude->>Claude: "Execute tests with MCP tools"
    Claude-->>Workflow: "Test results"
    
    Workflow->>Artifacts: "Upload JUnit test results"
    Workflow->>GitHub: "Annotate PR with test results"
    
    Workflow->>Workflow: "Detect Unity mode & secrets"
    Note over Workflow: Check for UNITY_LICENSE, ProjectSettings, Packages
    
    alt has_license == true && is_project == true
        Workflow->>Unity: "Unity compile (Project mode)"
        Unity->>Unity: "Run EditMode tests"
        Unity-->>Workflow: "Compilation results"
    else has_license == true && is_package == true
        Workflow->>Unity: "Unity compile (Package mode)"
        Unity->>Unity: "Compile package with Unity 2022.3.45f1"
        Unity-->>Workflow: "Compilation results"
    end
    
    Workflow->>Workflow: "Clean working tree"
    Workflow-->>GitHub: "Workflow complete"

Loading

_{1 file reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}