-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update Unity MCP server path in workflow #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Unity MCP server path in workflow #27
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes a critical path issue in the GitHub Actions workflow for the Claude NL suite. The change updates the Unity MCP server path from UnityMcpServer/src/server.py
to UnityMcpBridge/UnityMcpServer~/src/server.py
in the workflow configuration.
The fix addresses the actual Unity package structure where the Python MCP server is located within the UnityMcpBridge package directory. The UnityMcpServer~
subdirectory follows Unity's convention of using the tilde suffix for hidden/special directories that contain implementation details not directly exposed to Unity's asset system.
This change ensures the GitHub Actions workflow can properly locate and start the MCP server when running automated tests. The correction aligns the workflow configuration with the established codebase structure, where the UnityMcpBridge acts as the main Unity package container and houses the Python server implementation in the nested subdirectory.
Important Files Changed
Files Changed
Filename | Score | Overview |
---|---|---|
.github/workflows/claude-nl-suite.yml | 5/5 | Updated MCP server path from incorrect location to correct Unity package structure |
Confidence score: 5/5
- This PR is safe to merge with minimal risk
- Score reflects a simple but critical path correction with clear testing validation
- No files require special attention
Sequence Diagram
sequenceDiagram
participant User
participant GitHub
participant WorkflowRunner as "Workflow Runner"
participant Claude as "Claude AI"
participant UnityMCP as "Unity MCP Server"
participant Unity as "Unity Test Runner"
User->>GitHub: "Trigger workflow_dispatch"
GitHub->>WorkflowRunner: "Start claude-nl-suite job"
WorkflowRunner->>WorkflowRunner: "Checkout repository"
WorkflowRunner->>WorkflowRunner: "Install Python + uv"
WorkflowRunner->>WorkflowRunner: "Install Unity MCP server deps"
WorkflowRunner->>Claude: "Run Claude NL/T test suite"
Claude->>UnityMCP: "Call unity MCP tools (mcp__unity__*)"
UnityMCP-->>Claude: "Return tool results"
Claude-->>WorkflowRunner: "Complete test execution"
WorkflowRunner->>WorkflowRunner: "Upload JUnit test results"
WorkflowRunner->>GitHub: "Annotate PR with test results"
WorkflowRunner->>WorkflowRunner: "Detect Unity mode & secrets"
alt Unity Project with License
WorkflowRunner->>Unity: "Run Unity compile (Project mode)"
Unity-->>WorkflowRunner: "Compilation results"
else Unity Package with License
WorkflowRunner->>Unity: "Run Unity compile (Package mode)"
Unity-->>WorkflowRunner: "Compilation results"
end
WorkflowRunner->>WorkflowRunner: "Clean working tree"
WorkflowRunner-->>GitHub: "Workflow complete"
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugbot free trial expires on August 31, 2025
Learn more in the Cursor dashboard.
"unity": { | ||
"command": "python", | ||
"args": ["UnityMcpServer/src/server.py"] | ||
"args": ["UnityMcpBridge/UnityMcpServer~/src/server.py"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dependency Path Mismatch Causes Installation Failure
The MCP server path was updated to UnityMcpBridge/UnityMcpServer~/src/server.py
, but the earlier dependency installation step still looks for requirements.txt
at UnityMcpServer/requirements.txt
. This inconsistency means dependencies may not be installed, potentially causing the MCP server to fail.
Summary
Testing
pytest -q
https://chatgpt.com/codex/tasks/task_e_68a4504828a8832787ba73ff2ad37e61