Skip to content

Conversation

dsarno
Copy link
Owner

@dsarno dsarno commented Aug 19, 2025

Summary

  • fix workflow to point MCP server to correct path under UnityMcpBridge

Testing

  • pytest -q

https://chatgpt.com/codex/tasks/task_e_68a4504828a8832787ba73ff2ad37e61

Copy link

coderabbitai bot commented Aug 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-mcp-server-path-in-mcp_config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a critical path issue in the GitHub Actions workflow for the Claude NL suite. The change updates the Unity MCP server path from UnityMcpServer/src/server.py to UnityMcpBridge/UnityMcpServer~/src/server.py in the workflow configuration.

The fix addresses the actual Unity package structure where the Python MCP server is located within the UnityMcpBridge package directory. The UnityMcpServer~ subdirectory follows Unity's convention of using the tilde suffix for hidden/special directories that contain implementation details not directly exposed to Unity's asset system.

This change ensures the GitHub Actions workflow can properly locate and start the MCP server when running automated tests. The correction aligns the workflow configuration with the established codebase structure, where the UnityMcpBridge acts as the main Unity package container and houses the Python server implementation in the nested subdirectory.

Important Files Changed

Files Changed
Filename Score Overview
.github/workflows/claude-nl-suite.yml 5/5 Updated MCP server path from incorrect location to correct Unity package structure

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a simple but critical path correction with clear testing validation
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant GitHub
    participant WorkflowRunner as "Workflow Runner"
    participant Claude as "Claude AI"
    participant UnityMCP as "Unity MCP Server"
    participant Unity as "Unity Test Runner"

    User->>GitHub: "Trigger workflow_dispatch"
    GitHub->>WorkflowRunner: "Start claude-nl-suite job"
    
    WorkflowRunner->>WorkflowRunner: "Checkout repository"
    WorkflowRunner->>WorkflowRunner: "Install Python + uv"
    WorkflowRunner->>WorkflowRunner: "Install Unity MCP server deps"
    
    WorkflowRunner->>Claude: "Run Claude NL/T test suite"
    Claude->>UnityMCP: "Call unity MCP tools (mcp__unity__*)"
    UnityMCP-->>Claude: "Return tool results"
    Claude-->>WorkflowRunner: "Complete test execution"
    
    WorkflowRunner->>WorkflowRunner: "Upload JUnit test results"
    WorkflowRunner->>GitHub: "Annotate PR with test results"
    
    WorkflowRunner->>WorkflowRunner: "Detect Unity mode & secrets"
    
    alt Unity Project with License
        WorkflowRunner->>Unity: "Run Unity compile (Project mode)"
        Unity-->>WorkflowRunner: "Compilation results"
    else Unity Package with License
        WorkflowRunner->>Unity: "Run Unity compile (Package mode)"
        Unity-->>WorkflowRunner: "Compilation results"
    end
    
    WorkflowRunner->>WorkflowRunner: "Clean working tree"
    WorkflowRunner-->>GitHub: "Workflow complete"
Loading

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on August 31, 2025
Learn more in the Cursor dashboard.

"unity": {
"command": "python",
"args": ["UnityMcpServer/src/server.py"]
"args": ["UnityMcpBridge/UnityMcpServer~/src/server.py"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency Path Mismatch Causes Installation Failure

The MCP server path was updated to UnityMcpBridge/UnityMcpServer~/src/server.py, but the earlier dependency installation step still looks for requirements.txt at UnityMcpServer/requirements.txt. This inconsistency means dependencies may not be installed, potentially causing the MCP server to fail.

Fix in Cursor Fix in Web

@dsarno dsarno merged commit b26d7a1 into feat/nl-edits-ai-planner-prep Aug 19, 2025
2 checks passed
@dsarno dsarno deleted the codex/fix-mcp-server-path-in-mcp_config branch August 20, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant