-
Notifications
You must be signed in to change notification settings - Fork 0
CI: add Claude Desktop parity workflow #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughIntroduces a new GitHub Actions workflow to run Claude-based desktop parity tests for Unity MCP via a manual trigger. It sets up Python with uv, launches a Unity MCP server, and runs anthropics/claude-code-base-action with predefined tools, permissions, and prompt configuration. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GA as GitHub Actions
participant R as Repo
participant UV as Python+uv
participant Claude as claude-code-base-action
participant MCP as Unity MCP Server
Dev->>GA: Trigger workflow_dispatch
GA->>R: actions/checkout
GA->>UV: setup-uv (Python 3.11)
GA->>Claude: Run with model claude-3-7-sonnet-20250219<br/>allowed tools + auto-approvals
Claude->>UV: Launch MCP via mcp_config (stdio)
Claude->>MCP: Execute desktop parity test prompts
MCP-->>Claude: Responses / results
Claude-->>GA: Logs and completion within time/turn limits
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR introduces a new GitHub Actions workflow that implements automated testing parity between Claude Desktop and CI environments for the Unity MCP project. The workflow creates a "desktop parity" testing system that mirrors Claude Desktop's behavior by using the same AI model (claude-3-5-sonnet-20241022), similar timeout configurations, and identical MCP server setups.
The workflow sets up a Python environment using uv
, configures Claude AI with specific Unity MCP tools and permissions, then executes automated tests defined in .claude/prompts/nl-unity-suite.md
. This enables automated validation of Unity MCP functionality without requiring manual desktop testing, particularly for complex Unity script editing operations. The integration fits into the broader Unity MCP ecosystem by ensuring that the same AI-powered development capabilities available locally are also validated in CI pipelines.
Important Files Changed
Changed Files
Filename | Score | Overview |
---|---|---|
.github/workflows/claude-desktop-parity.yml |
2/5 | New CI workflow implementing Claude AI desktop parity testing with concerning path references and broad permissions |
Confidence score: 2/5
- This PR requires careful review due to potential breaking changes and configuration issues
- Score lowered due to invalid server path references, overly permissive auto-approval settings, and potentially resource-intensive workflow design
- Pay close attention to the workflow configuration file and verify server path exists before merging
Sequence Diagram
sequenceDiagram
participant User
participant "GitHub Actions" as GHA
participant "Unity MCP Server" as MCP
participant "Claude Agent" as Claude
participant "Unity Codebase" as Unity
User->>GHA: "Trigger workflow_dispatch"
GHA->>GHA: "Setup Ubuntu runner"
GHA->>GHA: "Checkout repository"
GHA->>GHA: "Install Python + uv"
GHA->>MCP: "Start Unity MCP Server via uv run"
MCP->>MCP: "Initialize with stdio transport"
GHA->>Claude: "Initialize claude-code-base-action"
Claude->>GHA: "Load prompt from .claude/prompts/nl-unity-suite.md"
Claude->>MCP: "Connect via MCP protocol"
MCP->>Claude: "Expose Unity tools (mcp__unity__*)"
loop "Up to 60 turns or 15 min timeout"
Claude->>Unity: "Execute Unity operations via MCP tools"
Unity->>Claude: "Return Unity state/results"
Claude->>Unity: "Read/Write/Edit Unity files"
Unity->>Claude: "File operation results"
Claude->>GHA: "Execute Bash commands (git, etc.)"
GHA->>Claude: "Command execution results"
end
Claude->>GHA: "Complete desktop parity testing"
GHA->>User: "Workflow completion status"
1 file reviewed, 1 comment
"mcpServers": { | ||
"unity": { | ||
"command": "uv", | ||
"args": ["run","--directory","UnityMcpBridge/UnityMcpServer~/src","python","server.py"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Path 'UnityMcpBridge/UnityMcpServer~/src' doesn't exist in repository. Check actual MCP server location.
Summary by CodeRabbit
Tests
Chores