Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Save for the editors #10

Open
dschaefer opened this issue Jan 13, 2017 · 2 comments
Open

Implement Save for the editors #10

dschaefer opened this issue Jan 13, 2017 · 2 comments

Comments

@dschaefer
Copy link
Owner

Right now all you can do is open files to look at them and then close the tab. Would be good to implement save so you can save changes (yes, we're that early in this thing). Start with grabbing the Command/Control S key action and save the contents of the currently active editor into it's filePath. Also implement a dirty bit so we don't save if there hasn't been changes and so that we don't close the tab if the editor is dirty without asking the user.

@marckhouzam
Copy link

How about going full auto-save right away?

@dschaefer
Copy link
Owner Author

Baby steps. First I need to learn how to save at all. Monaco doesn't have a "save" function so I'll have to construct that. Then just bind it to the right key.

I'm also not sure auto-save is a feature that most developers want. We need to study that a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants