-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Module with Tests and 100% Test Coverage #8
base: master
Are you sure you want to change the base?
Conversation
…ndency badge to readme
this.envfile = path.join(process.cwd(), envfile || 'env.json') | ||
this.evars = (path.existsSync(this.envfile)) ? require(this.envfile) : {} | ||
this.envfile = envfile || path.resolve(process.cwd() + '/env.json'); | ||
this.evars = (fs.statSync(this.envfile)) && require(this.envfile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use fs.statSync
because if the env.json
file does not exist most apps probably wont work to the error (with full stack trace) is appropriate. what do you think?
@dshaw please let us know if anything is missing to get this PR merged. |
Why this PR stills Open?? (not merged 🐛 🐛 ) |
Hi @dshaw,
As promised: #6 here's the Pull Request with the update to latest node.js (apologies for taking so long, we got "distracted" with our work... 😉 )
What's included in the PR?
Please let us know if this is ok. otherwise let us know what you would prefer us to change.
Thanks!
N 🚀