Skip to content

Change the .off() function to use .fitlerNot #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

dsrees
Copy link
Owner

@dsrees dsrees commented Jul 17, 2018

Closes #5

  • Fixed the .off() method which needed to used .filterNot instead of .filter in order to remove the single handler instead of all other handlers by using the .filterNot closure instead
  • Added some tests for the .off() method
  • Added some other tests for the Channel class

@dsrees dsrees merged commit 6ab73b5 into master Jul 17, 2018
@dsrees dsrees deleted the dr/off_override_bindings branch July 17, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant