-
Notifications
You must be signed in to change notification settings - Fork 197
Add digital ocean and amd dev backend #3030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digital ocean and amd dev backend #3030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bihan, thanks for the PR. The division into two backends looks good to me 👍 Please also see my comments about some implementation details
src/dstack/_internal/core/backends/digitalocean_base/compute.py
Outdated
Show resolved
Hide resolved
src/dstack/_internal/core/backends/digitalocean_base/api_client.py
Outdated
Show resolved
Hide resolved
src/dstack/_internal/core/backends/digitalocean_base/compute.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bihan, thanks for the update. I think we are almost ready to merge. The remaining things are:
- Bump
gpuhunt
to0.1.8
inpyproject.toml
- Address my non-nitpicking comments on the latest update
- Optionally address my nitpicking comments
If you decide to follow my code suggestions and there will be no details to discuss, feel free to merge without repeating the review. Thank you!
src/dstack/_internal/core/backends/digitalocean_base/api_client.py
Outdated
Show resolved
Hide resolved
src/dstack/_internal/core/backends/digitalocean_base/compute.py
Outdated
Show resolved
Hide resolved
src/dstack/_internal/core/backends/digitalocean_base/compute.py
Outdated
Show resolved
Hide resolved
…t.py Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
Co-authored-by: jvstme <36324149+jvstme@users.noreply.github.com>
Steps
Login to both clouds https://cloud.digitalocean.com/login and https://amd.digitalocean.com/login
To configure backends add
Note: Will be updating the PR with project_name configuration. Creation of Droplet (VM) was not documented in api reference, but recently found that "project_id" field works.