Add a new opt-in job network mode #3043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new `DSTACK_SERVER_JOB_NETWORK_MODE` with three modes:
- HOST_FOR_MULTINODE_ONLY (1)
The new opt-in mode.
"bridge" by default, unless it's a multinode run
- HOST_WHEN_POSSIBLE (2)
The current default.
"host" by default, unless the job occupies only a part of
the instance.
- FORCED_BRIDGE (3)
Same as legacy DSTACK_FORCE_BRIDGE_NETWORK=true
Always "bridge", even for multinode runs.
To opt-in:
export DSTACK_SERVER_JOB_NETWORK_MODE=1
`DSTACK_FORCE_BRIDGE_NETWORK` is deprecated but supported with
a migration warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
DSTACK_SERVER_JOB_NETWORK_MODEwith three modes:To opt-in:
DSTACK_FORCE_BRIDGE_NETWORKis deprecated but supported with a migration warning