libkd/an-fls.h licensed as GPL v2

[rikmills]

This has caused the rejection of the stellarsolver source from Debian which incorporates libkd from astrometry.

https://lists.debian.org/debian-qt-kde/2021/02/msg00114.html

in this package there are files under the GPL-2 (stellarsolver/astrometry/libkd/an-fls.h) mixed with files under GPL-3+.
According to [1] this is not allowed.

Thorsten

[1] https://www.gnu.org/licenses/gpl-faq.en.html#AllCompatibility

See: rlancaste/stellarsolver#76

[dstndstn]

If you want to contribute a clean-room replacement licensed in BSD-3, go ahead.

The required function signature is simple:

/**

• fls - find last (most-significant) bit set
• Eg, fls(0) = 0, fls(1) = 1, fls(0x80000000) = 32.
  */
  static inline int an_fls(int x);

cheers,
--dustin

[rlancaste]

Isn't this a problem for astrometry.net as well since I think from what I just saw in looking at the code, the code was taken from the linux kernel which according to this is distributed under GPL V2 while astrometry.net is licensed under GPL V3. So I think it affects more than just my project.

[dstndstn]

Uh, yes, you're correct.

…

On Thu, Feb 11, 2021 at 10:58 AM rlancasteAstro ***@***.***> wrote: Isn't this a problem for astrometry.net as well since I think from what I just saw in looking at the code, the code was taken from the linux kernel which according to this is distributed under GPL V2 while astrometry.net is licensed under GPL V3. So I think it affects more than just my project. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIEH7KZRXXX46X3SILSP3LS6P5DLANCNFSM4XO7S7ZA> .

[dstndstn]

I just updated our LICENSE statement to reflect this.

…

On Thu, Feb 11, 2021 at 11:13 AM Dustin Lang ***@***.***> wrote: Uh, yes, you're correct. On Thu, Feb 11, 2021 at 10:58 AM rlancasteAstro ***@***.***> wrote: > Isn't this a problem for astrometry.net as well since I think from what > I just saw in looking at the code, the code was taken from the linux kernel > which according to this is distributed under GPL V2 while astrometry.net > is licensed under GPL V3. So I think it affects more than just my project. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#212 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAIEH7KZRXXX46X3SILSP3LS6P5DLANCNFSM4XO7S7ZA> > . >

[pinotree]

Just to make things a bit more explicitl:

• libkd/an-fls.h is GPL v2 (only)
• include/astrometry/ctmf.h and util/ctmf.c are GPL 3+

IANAL: even ignoring the majority of the files (that are licensed as BSD), to me this means that the resulting binary cannot be distributed, as there is no "intersection" in the allowed licenses.

[dstndstn]

If I'm not mistaken, we are in row 1, column 2, which is OK*.

[dstndstn]

Regardless, in e1b21dc I swapped in the FreeBSD version of this function, and in later commits updated the license statement.

[dstndstn]

@rikmills , please let me know if you'd like me to a cut a new release with this change, for checking with Debian.

[rikmills]

@rikmills , please let me know if you'd like me to a cut a new release with this change, for checking with Debian.

Well, @pinotree is the actual Debian developer here who had stellarsolver rejected, so I defer to his opinion is he is willing to give it.

[rlancaste]

Thank you very much Dustin for addressing the issue so quickly!! I am sorry I wasn't able to be much help, since I have been extremely busy with my real job the last month or so. Hybrid teaching has taken a whole lot of work on my part, so I haven't had as much time for my astronomy and coding hobbies. I will update the copy of this file in the StellarSolver repo this weekend.

Just a note though, if I am understanding this issue completely, this means that any astronomy program that has bundled a binary version of astrometry.net or a binary version of any astrometry.net derivative based on the code before this update will also have a serious license issue and should be updated to include this change. That would probably affect a number of programs over the last few years. Although if they just distributed the source code and the users built the binaries on their own system and didn't distribute the binaries they built, that would be fine. Would that be correct?

[dstndstn]

I'm afraid I do not know any of the legalities of distributing binaries -- I never do that so it's just not in my wheelhouse.

[rlancaste]

Thats not a problem, and I don't think that is your responsibility by any means, you do tons of great work with creating, maintaining and improving astrometry.net. I was just asking mainly to get clarification from any of the posters in this thread since we might want to let some folks know they need to update.

I can take care of StellarSolver and KStars. I can also inform Jasem about it so he can take care of anything he might have control over in INDI, his PPA, or other open source locations. I can also let Cloudmakers know about it so they can update the Mac Astrometry program. But I know astrometry.net binaries have been distributed for years in homebrew and in the package distributions systems of various Linux based systems's like Ubuntu and Arch Linux. If I understand this right, they should be informed they need to update. There is also the Cygwin based ANSVR. And I don't know what other programs on Windows bundle an astrometry solver inside. Jasem might know who to tell. I can do my best to get the word out if this is needed.

[rikmills]

Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983306

[dstndstn]

Releases 0.85 and 0.86 should have this fixed.