Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 384 agg stat total dir #389

Merged
merged 34 commits into from
Jun 28, 2024
Merged

Conversation

bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

  • ran updated test_agg_stat.py tests

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • optional: run the test_agg_stat.py tests

  • verify all GHA tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    updated input data

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe: most likely flagged for duplicate code in the test_agg_stat.py code

  • Please complete this pull request review by [ASAP].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 30 commits June 21, 2024 20:00
…0409_120000V_vl1l2.txt

out of date now that TOTAL_DIR column has been added
out of date with addition of the TOTAL_DIR column
out of date, no longer relevant
…were removed, causing error messages about no files found
Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on seneca, all tests passed.

@hankenstein2 hankenstein2 merged commit d7631db into develop Jun 28, 2024
7 checks passed
@hankenstein2 hankenstein2 deleted the feature_384_agg_stat_total_dir branch June 28, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
2 participants