-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 384 agg stat total dir #389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on vl1l2 data with the total_dir column
…0409_120000V_vl1l2.txt out of date now that TOTAL_DIR column has been added
out of date with addition of the TOTAL_DIR column
out of date, no longer relevant
…tcenter/METcalcpy into feature_384_agg_stat_total_dir
…were removed, causing error messages about no files found
…_20120409_120000V_vcnt.txt incorrect file
…feature_384_agg_stat_total_dir
…tcenter/METcalcpy into feature_384_agg_stat_total_dir
…he associated ME, MAE, and MSE stats
…0409_120000V_val1l2.txt out of date
created with out of date MET data
not used
…0409_120000V_vcnt.txt out of date
22 tasks
hankenstein2
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran on seneca, all tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
ran updated test_agg_stat.py tests
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
optional: run the test_agg_stat.py tests
verify all GHA tests pass
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
updated input data
Do these changes introduce new SonarQube findings? [Yes]
If yes, please describe: most likely flagged for duplicate code in the test_agg_stat.py code
Please complete this pull request review by [ASAP].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases