Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0 [WIP] #272

Closed
wants to merge 46 commits into from
Closed

2.0 [WIP] #272

wants to merge 46 commits into from

Conversation

milesj
Copy link
Contributor

@milesj milesj commented Jul 25, 2017

The entire refactor that is v2.0.

Nathan-Schwartz and others added 30 commits July 24, 2017 21:46
@Nathan-Schwartz @milesj
Rename variable from Vantage to Vorpal
8e39667
@milesj
Updated deps and switched to Yarn.
ac1d48b
@milesj
Updated Inquirer and other prod deps.
a3ea141
@jbrumwell @milesj
Support default values for options
7c38999
@jbrumwell @milesj
Review fixes
7d94962
@milesj
Remove dist folder.
ce2707f
@milesj
Replaced Gulp with NPM scripts. Updated to use milesj/build-tool-conf…
03ef70d 
…ig for Babel and ESLint.
@milesj
Updated changelog.
0c921e2
@milesj
Updated changelog.
c4dd42a
@milesj
Removed Babel. Updating Node.js req to 6.10.
364d26d
@milesj
Fix travis config.
8a8b092
@milesj
Converted command-instance to ES2015.
490825b
@milesj
Updated to use require().
7445f86
@milesj
Convert Command to ES2015.
0f47ab7
@Nathan-Schwartz @milesj
Update lib/history.js to ES2015
e129562
@milesj
Converted UI to ES2015.
ae0a2ed
@laurent22 @milesj
Fixed crash when persisted history cannot be parsed
58ec387 
Under some rare conditions, Vorpal can produce an invalid persisted history which, when loaded, would result in an uncaught exception that crashes the caller. To prevent this, the history is reset when invalid JSON is loaded.
@milesj
Moving utils into files. Refactored to ES2015.
3f16dec
@milesj
Porting more utils to functions.
7134fa6
@milesj
More debugging on why it doesnt work.
a209444
@milesj
More work on getting it to render.
760488b
@milesj
Updated deps.
e4ff727
@milesj
Fix logging problem.
2f24c4f
@milesj
Added flow. Reintegrated babel.
a4a7b4f
@milesj
Ported more utils to flow.
c90320e
@milesj
Added matchCommand.
2994e66
@milesj
Fixed tests.
e26d7d1
@milesj
Updated parseCommand.
44ca9d2
@milesj
Updated buildCommandArgs.
0d06e34
@milesj
Updated deps.
56a96f9
@milesj
Copy link
Contributor Author

milesj commented Aug 3, 2017

Works for me!

@E314c
Copy link

E314c commented Oct 16, 2017

Whats the current status for this? Anything I can help with?

@milesj
Copy link
Contributor Author

milesj commented Oct 16, 2017

@E314c I've been a bit swamped with other projects, but hoping to get back on this soon.

@AdrieanKhisbe
Copy link
Contributor

@milesj Any news?

@milesj
Copy link
Contributor Author

milesj commented Jan 26, 2018

Same response. Have some other projects I need to get out of the way first. About half way through them.

@AdrieanKhisbe
Copy link
Contributor

Good luck with them then ! 😃
(In case you need a hand, I could help)

@AdrieanKhisbe
Copy link
Contributor

I have some improvement to vorpal in mind that are breaking changes.
Will open some issue for them as base of discussion, then build up PR toward this branch on some discussion has occurred.

Once open will post links there.

This was referenced Oct 7, 2018
Open
Open
Open
@Ore4444
Copy link

Ore4444 commented Oct 23, 2018

Hey, are you open for contributions on the 2.0 branch? I can help.

@milesj
Copy link
Contributor Author

milesj commented Oct 24, 2018

@Ore4444 This PR is so far out of date, might be best just to start over, and possibly write it in TypeScript. I don't really have time to do it, but I can review PRs.

@Ore4444
Copy link

Ore4444 commented Oct 24, 2018

@milesj I might actually take it upon myself to migrate Vorpal to TypeScript.
Should I work directly on top of master? Should I ignore any past discussions about roadmap and future of the project?

Should I open a focused PR with just TypeScript migration of all current functionality?

@milesj
Copy link
Contributor Author

milesj commented Oct 24, 2018

@Ore4444 I can cut a 2.0 TS branch in which you can submit PRs too.

@Ore4444
Copy link

Ore4444 commented Oct 25, 2018

@milesj cool, I'd like that.

My focus will be only on re-writing Vorpal in TypeScript without adding/changing any functionality.

Other than all tests having to pass, are there more things I need to keep in mind and validate before submitting the PR?

@milesj
Copy link
Contributor Author

milesj commented Oct 25, 2018 •
edited
Loading

@Ore4444 Would also make sure the deps are up to date, and probably replace minimist with yargs.

I created the branch you can cut from: https://github.com/dthree/vorpal/tree/2.0-ts Might be easiest to submit PRs piece meal.

@Ore4444
Copy link

Ore4444 commented Oct 27, 2018 •
edited
Loading

@milesj Cool. I think I can't push to this branch. I get 403. Possible?

@milesj
Copy link
Contributor Author

milesj commented Oct 28, 2018

@Ore4444 You need to submit PRs to it, not push to it.

@Ore4444
Copy link

Ore4444 commented Oct 28, 2018

Yep, got it.

@Ore4444 Ore4444 mentioned this pull request Oct 28, 2018
Open
@milesj milesj closed this Mar 7, 2019
@ShadiestGoat
Copy link

Hey, why was this closed?

@dthree
Copy link
Owner

dthree commented Jul 23, 2021

I just dont think its being worked on anymore. Vorpal needs an overhaul, which I will be doing at some point in the future and addressing all issues.

@dthree dthree reopened this Jul 23, 2021
@ShadiestGoat
Copy link

Hey, if you will be working on that, can you open an issue with a list of fixes? Do you plan on making it in Typescript?

@milesj
Copy link
Contributor Author

milesj commented Jul 24, 2021

I went ahead and just built my own CLI: https://boostlib.dev/docs/cli

@milesj milesj closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@milesj @dthree @newoga @E314c @AdrieanKhisbe @Ore4444 @ShadiestGoat @Nathan-Schwartz @jbrumwell @laurent22