[DRAFT] TypeScript Vorpal #328
Conversation
|
The flow types here might be useful in typing some of the TS stuff: https://github.com/dthree/vorpal/pull/272/files#diff-3a699a0719518f967e9b2df3f5549e02 |
| // "noEmit": true, /* Do not emit outputs. */ | ||
|
|
||
| /* Strict mode */ | ||
| "strict": false, /* Enable all strict type-checking options. */ |
There was a problem hiding this comment.
Yes, I'll change it once TSC gives no errors for strict false.
|
Any movement on this? I don't mind helping out 😄 |
|
@OzairP i added you as a collaborator to my fork. Feel free to add commits. I might have time soon to continue developing it. Meanwhile, I will for sure be able to review your code |
|
Do you need help getting this fork rolling? I'd be glad to hop on board with it as well. I've noticed the |
|
@slinkardbrandon any help is welcome. I won't have time to write code soon, but I will be able to review commits and help with what I can. Added you as a collaborator |
|
@OzairP cross posting this from #334 (comment):
|
|
Yep and so anyone reading this doesn’t think we’re splitting the effort unintentionally, we’ve pulled in Ore’s work into that org for now while we work. This gives us proper git control and allows us to review all changes before merging into the fork directly. |
|
is anybody still interested to do this.. I mean contribute to this project? I've made (not published yet) a complete remake of vorpal (changing also the name) made in typescript, with less code, less buggy, less and up-to-date properties and more features such as project generator (as in oclif), etc... It has been a long work, I re-wrote the whole code few times before deciding to keep this version, so I'm also kind of jealous and protective about my work. If anyone is interested to actively help me send a DM on twitter and I can share you permissions for accessing the code. It's not published yet because I want to avoid the waterfall effect of potential many people switching from vorpal to this new version without being fully tested. Edit: Btw, vorpal was a great project but it's clearly dead, also the code is a mess, that's why I didn't bother to fork and make a PR. |
|
Hi! I'm a TypeScript fan and recently I'm falling in love with vorpal too. This PR seems a good start of upgrading vorpal to be easy to maintain and use, would love to see it to be merged! |
As this repo seems to no longer be maintained some folks started work on that right here: https://github.com/vorpaljs-reforged/vorpal |
|
@sweethuman Thank you very much for telling me that our community has a TypeScript-ed version of the Vorpal, it looks great! However, I can not find the NPM module for the vorpaljs-reforged, so how can I install that module, do we need to install it from the GitHub? Do we have any plan to publish it as a fork version on NPM or our plan is to merge it back to the official vorpal in the future? |
|
It will be published in npm at one point, just use it from github |
|
@huan I'm one of the contributors to the vorpaljs-reforged project, but unfortunately, work on it has slowed down quite a bit in the last 6 months. The vorpal source code is also a bit hard to work with, which is the main reason I decided to create a new project using a similar API to vorpal, maybe you find it useful: https://github.com/hongaar/bandersnatch. Would love to hear what you think! |
|
@hongaar Your project looks great, a very nice typing system with a clearer code base! |
As discussed in #272:
The focus of this PR will be on re-writing Vorpal in TypeScript without adding/changing any functionality.
@milesj: