Skip to content

Commit

Permalink
Fix script/regression/benchmark.py rework
Browse files Browse the repository at this point in the history
Avoid running whole list of tests, but tests only failed ones
  • Loading branch information
carlopi committed Nov 24, 2024
1 parent 1a3d614 commit c70f79f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions scripts/regression/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ def run_benchmark(self, benchmark) -> Union[float, str]:
print(err)
return 'Failed to run benchmark ' + benchmark

def run_benchmarks(self):
def run_benchmarks(self, benchmark_list: List[str]):
results = {}
for benchmark in self.benchmark_list:
for benchmark in benchmark_list:
results[benchmark] = self.run_benchmark(benchmark)
return results

Expand Down
4 changes: 2 additions & 2 deletions scripts/regression/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ class BenchmarkResult:
'''
)

old_results = old_runner.run_benchmarks()
new_results = new_runner.run_benchmarks()
old_results = old_runner.run_benchmarks(benchmark_list)
new_results = new_runner.run_benchmarks(benchmark_list)

for benchmark in benchmark_list:
old_res = old_results[benchmark]
Expand Down

0 comments on commit c70f79f

Please sign in to comment.