ADS: AppTP: Manage Apps #2667
Closed
ADS: AppTP: Manage Apps #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203418290512953 ### Description - Support the textColor attribute from Android - When textType and textColor are both set, textType will take priority.
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203425281067996 ### Description The top triangle in the DaxDialog doesn't respect elevation. The outline around it is not consistent with the rest of the Card. ### UI changes | Before | After | | ------ | ----- | ||
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL:
https://app.asana.com/0/1202857801505092/1203433424223914/f
### Description
Increase padding-end for OneLineListItem and TwoLineListItem when
showing switch
### Steps to test this PR
- Install from this branch
- Go to Settings > Design Preview
- [ ] Check List Items with toggle look as expected
### UI changes
| Before | After |
| ------ | ----- |
||
Task/Issue URL: https://app.asana.com/0/488551667048375/1203325011590293 ### Description Update Onboarding to ADS ### UI changes | Onboarding | Onboarding | Onboarding | Onboarding | | ------ | ----- | ------ | ----- | ||||
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203425281067996 ### Description The top triangle in the DaxDialog doesn't respect elevation. The outline around it is not consistent with the rest of the Card. ### UI changes | Before | After | | ------ | ----- | ||
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL: https://app.asana.com/0/0/1203418963160798/f
### Description
Global Privacy Control screen 100% migrated to new components
### Steps to test this PR
- Install from this branch
- Go to Settings > Global Privacy Control (GPC)
- [ ] Check screen looks as expected
### UI changes
| Before | After |
| ------ | ----- |
||
||
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->
Task/Issue URL: https://app.asana.com/0/0/1203418963160799/f
### Description
Manage Cookie Pop-ups screen 100% migrated to new components
### Steps to test this PR
- Install from this branch
- Go to Settings > Manage Cookie Pop-ups
- [ ] Check screen looks as expected
### UI changes
| Before | After |
| ------ | ----- |
||
||
Task/Issue URL: https://app.asana.com/0/0/1203418963160797/f ### Description Accessibility screen 100% migrated to new components ### Steps to test this PR - Install from this branch - Go to Settings > Accessibility - [ ] Check screen looks as expected ### UI changes | Before | After | | ------ | ----- | || ||
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 ### Description Update toolbar, statusbar and navigation bar colors to latest spec ### UI changes | Light | Dark| | ------ | ----- | || Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 ### Description Update toolbar, statusbar and navigation bar colors to latest spec ### UI changes | Light | Dark| | ------ | ----- | || Co-authored-by: David González <malmstein@gmail.com>
Task/Issue URL: https://app.asana.com/0/488551667048375/1203325011590293 Update Onboarding to ADS | Onboarding | Onboarding | Onboarding | Onboarding | | ------ | ----- | ------ | ----- | ||||
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 ### Description Update toolbar, statusbar and navigation bar colors to latest spec ### UI changes | Light | Dark| | ------ | ----- | || Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 ### Description Update toolbar, statusbar and navigation bar colors to latest spec ### UI changes | Light | Dark| | ------ | ----- | || Co-authored-by: David González <malmstein@gmail.com>
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203456015669172/f ### Description - Selected option was not working for RadioListAlertDialogBuilder - Disable positive button if no option is selected by default ### UI changes | Before | After | | ------ | ----- | || ||
Task/Issue URL: https://app.asana.com/0/0/1203418963160800/f ### Description Migrate internal features settings section to new components
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203438184524173 ### Description Update typograhpy to use lineHeight instead of lineSpacingExtra Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203310952591148 ### Description Design Review in https://app.asana.com/0/1174433894299346/1203455585574660 Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Task/Issue URL: https://app.asana.com/0/0/1203467500325942/f ### Description Migration of Fireproof Websites screen to new components ### Steps to test this PR - Install from this branch - Go to Settings > Fireproof Websites - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | || ||
Task/Issue URL: https://app.asana.com/0/0/1203411647299661/f Migrate Settings screen and small section to new components - Main Settings menu - Theme Dialog - App Icon Screen - Fire Button Animation Dialog - Automatically Clear... Dialog - Clear On... Dialog - Open Links in Apps Dialog - DuckSuckGo Desktop App Screen - About DuckDuckGo Screen - Install from this branch - Go to Settings - [ ] Check settings menu, dialogs and screens mention in description look as expected | Before | After | | ------ | ----- | || Co-authored-by: David González <malmstein@gmail.com>
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203480450171661/f ### Description Fix for making radiogroup scrollable if content is too long ### Steps to test this PR - Install from this branch - Change your device language to Russian - Go to Settings > Clear On... - [ ] Check content is scrollable ### UI changes | Before | After | | ------ | ----- | |https://user-images.githubusercontent.com/20798495/206157619-bab38fb5-90bb-486a-b3ba-efd61b334d31.mp4|
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203501746286788 ### Description Update divider color attribute in dark mode
Task/Issue URL: https://app.asana.com/0/0/1203411647299660/f ### Description Migrate Site permissions section to new components ### Steps to test this PR - Install from this branch - Go to Settings > Site Permissions - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | || ||
Task/Issue URL: https://app.asana.com/0/0/1203467500325941/f ### Description - Migrate Unprotected Sites screen to new components - Created new CustomAlertDialog component ### Steps to test this PR - Install from this branch - Go to Settings > Unprotected Sites - [ ] Check screen look as expected ### UI changes | Before | After | | ------ | ----- | ||
Task/Issue URL: https://app.asana.com/0/0/1203411647299663/f ### Description Migrate Downloads screen to new components ### Steps to test this PR - Install from this branch - Go to Downloads - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | ||
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203501746286791 Description Update TextInput to latest specs
Task/Issue URL: https://app.asana.com/0/inbox/1157893581871899/1203455585574665/1203472619504664 ### Description System Search changes Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
This was referenced Dec 19, 2022
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|](https://user-images.githubusercontent.com/531613/203578300-1a80b73e-cb28-441c-831c-cb9a1307319f.png)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203793730-c9d9883e-c2a8-48bd-8a9e-6c19288f2f92.jpg)||){kind=link}
|||](https://user-images.githubusercontent.com/531613/203755369-9dcee675-b819-428f-a1b3-8351a910ba24.png)||||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203757021-1b931a7a-dfbb-41fb-92af-e30c6faa88f9.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203757037-57eb0cff-cd1b-4342-bece-42d22f06ea46.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203774974-082d4088-f957-4be8-81aa-7e8735eed21e.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203774991-473012a1-a9c7-40a4-b97d-be230f07614a.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203611688-2e940e30-79a6-46b6-b641-02c162f975a7.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/203759120-a2230381-80c3-4648-a79b-e6d79f0a624d.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/531613/204002612-76f95631-0dea-4bb4-a84a-251150a0dfb5.png)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/204546959-54f42f96-fffc-42bc-9821-b39f7d201146.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/204546959-54f42f96-fffc-42bc-9821-b39f7d201146.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/205285445-88b27ff9-1484-4bf0-9545-e65b64691feb.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/205285469-b0e3c39d-0def-434f-b036-61b8f812a2e0.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/204876902-c02e41a3-6ff4-40a9-9b04-82cf8206b2d6.jpg)||){kind=link}
|https://user-images.githubusercontent.com/20798495/206157619-bab38fb5-90bb-486a-b3ba-efd61b334d31.mp4|){kind=link}
|](https://user-images.githubusercontent.com/20798495/205287199-ca0c20df-0df7-41f5-aac0-3d617553f16c.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/205287213-f2fdb15d-2750-42f0-9def-7897eedb2fdc.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/205987523-0e85ae6f-3fb7-4e9a-a71c-23f396584966.jpg)||){kind=link}
|](https://user-images.githubusercontent.com/20798495/206199425-9fbdb8a9-3b6e-4796-975d-ed1d0ed603bf.jpg)||){kind=link}
This was referenced Dec 19, 2022
malmstein
changed the title
malmstein
force-pushed
the
12-19-section_headers_in_trackers_screen
branch
from
b6420af
to
7d4fb6f
Compare
This was referenced Dec 20, 2022
Merged
Merged
Merged
Closed
This was referenced Dec 28, 2022
Closed
This was referenced Jan 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description
Steps to test this PR
Feature 1
UI changes