Skip to content

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 12, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209132650948830/f

Description

A regression was introduced that affects multiple open windows.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane marked this pull request as ready for review January 12, 2025 16:07
@shakyShane shakyShane requested review from mgurgel and a team as code owners January 12, 2025 16:07
@shakyShane
Copy link
Contributor Author

shakyShane commented Jan 12, 2025

Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit b493e39
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6783e9abe8623500081c2418
😎 Deploy Preview https://deploy-preview-1387--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 12, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 12, 2025

[Beta] Generated file diff

Time updated: Sun, 12 Jan 2025 16:12:24 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@shakyShane shakyShane merged commit 7e8432f into main Jan 13, 2025
14 checks passed
@shakyShane shakyShane deleted the 01-12-ntp_ensure_cross-window_sections_collapse branch January 13, 2025 09:51
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
* ntp: ensure cross-window sections collapse

* style regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants